Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store maskinporten scopes in db #13930

Merged
merged 20 commits into from
Oct 30, 2024
Merged

feat: store maskinporten scopes in db #13930

merged 20 commits into from
Oct 30, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Oct 28, 2024 •
edited
Loading

Description

Db migration added for AppScopes.
Upsert and get endpoints added

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. backend kind/dependencies Used for issues or pull requests that are dependency updates labels Oct 28, 2024
@mirkoSekulic mirkoSekulic marked this pull request as draft October 28, 2024 09:48
@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Oct 28, 2024
@mirkoSekulic mirkoSekulic force-pushed the feature/scopes-models branch 5 times, most recently from b57e650 to 4804253 Compare October 28, 2024 18:06
@mirkoSekulic mirkoSekulic marked this pull request as ready for review October 28, 2024 18:20
@mirkoSekulic mirkoSekulic linked an issue Oct 29, 2024 that may be closed by this pull request
Modeling the database to store scopes #12767
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (34fd4d4) to head (6e014ea).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13930   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files        1673     1673           
  Lines       22191    22191           
  Branches     2609     2609           
=======================================
  Hits        21111    21111           
  Misses        834      834           
  Partials      246      246

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

framitdavid
framitdavid approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mirkoSekulic mirkoSekulic added skip-manual-testing PRs that do not need to be tested manually and removed skip-releasenotes Issues that do not make sense to list in our release notes labels Oct 30, 2024
@mirkoSekulic mirkoSekulic merged commit 4adfb65 into main Oct 30, 2024
29 of 31 checks passed
@mirkoSekulic mirkoSekulic deleted the feature/scopes-models branch October 30, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@framitdavid framitdavid framitdavid approved these changes

Assignees
No one assigned
Labels
backend kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modeling the database to store scopes
2 participants
@mirkoSekulic @framitdavid